create-cluster clean now will clean appendonlydir#10223
Merged
oranagra merged 3 commits intoredis:unstablefrom Feb 7, 2022
Merged
create-cluster clean now will clean appendonlydir#10223oranagra merged 3 commits intoredis:unstablefrom
oranagra merged 3 commits intoredis:unstablefrom
Conversation
In redis#9788, now we stores all persistent append-only files in a dedicated directory. The name of the directory is determined by the appenddirname configuration parameter in redis.conf Update create-cluster clean to clean this default directory. Fixes redis#10222
oranagra
approved these changes
Feb 1, 2022
Member
There was a problem hiding this comment.
@chenyang8094 FYI use case of multiple nodes in one folder.
maybe instead we wanna let each node have a separate folder?
current code gives each one a different appendfilename.
not sure if some users of this script expect it to sometimes start from old persistence files (on upgrade)?
Contributor
Author
yes, i also found this after submitting. i also do some cleanups(see if this needed) |
Member
Collaborator
|
@oranagra Maybe it's a kind of wishful thinking, but I tend to assume this script is only used for toy / test environments. |
oranagra
approved these changes
Feb 2, 2022
Contributor
|
@oranagra Got, thank you. |
Contributor
|
AFAIK it's only used for test environments as well. |
madolson
approved these changes
Feb 7, 2022
enjoy-binbin
added
the
state:to-be-merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9788, now we stores all persistent append-only files in
a dedicated directory. The name of the directory is determined
by the appenddirname configuration parameter in redis.conf
Update create-cluster clean to clean this default directory.
Each node have a separate folder
appendonlydir-{PORT}.This PR also do some cleanups, logs and stricter wildcard matching.
Fixes #10222