Fix fcall_ro key spec flags in commands.c#10145
Merged
oranagra merged 1 commit intoredis:unstablefrom Jan 19, 2022
Merged
Conversation
In redis#10122, we modify the key spec flags to `RO` and `ACCESS`. But forgot to call generate-command-code.py. Also formatted it to follow the Python PEP8.
enjoy-binbin
added
the
state:to-be-merged
oranagra
approved these changes
Jan 19, 2022
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
sorry. i committed my edit without building it.
no real harm in that, since the next one who updates this file will bring these changes here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10122, we modify the key spec flags to
ROandACCESS.But forgot to call generate-command-code.py. Also formatted
it to follow the Python PEP8.