Skip to content

Add test case to improve code coverage for Addslotsrange and Delslotsrange command#10128

Merged
madolson merged 2 commits intoredis:unstablefrom
hwware:cluster-test
Feb 3, 2022
Merged

Add test case to improve code coverage for Addslotsrange and Delslotsrange command#10128
madolson merged 2 commits intoredis:unstablefrom
hwware:cluster-test

Conversation

@hwware
Copy link
Contributor

@hwware hwware commented Jan 17, 2022

No description provided.

@hwware hwware changed the title Improve code coverage for Addslotsrange and Delslotsrange command Add test case to improve code coverage for Addslotsrange and Delslotsrange command Jan 17, 2022
@hwware hwware requested review from madolson and oranagra January 17, 2022 22:15
madolson
madolson reviewed Jan 18, 2022
View reviewed changes
madolson
madolson approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing, merging.

https://github.com/redis/redis/runs/5046000260?check_suite_focus=true

@madolson madolson merged commit c9e1602 into redis:unstable Feb 3, 2022
enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Feb 4, 2022
@enjoy-binbin
Fix cluster tests failing due to subcommand names
c6a84f9 
Introduced in redis#10128
@enjoy-binbin enjoy-binbin mentioned this pull request Feb 4, 2022
Merged
@enjoy-binbin
Copy link
Contributor

enjoy-binbin commented Feb 4, 2022

the tests failed, look like the branch did not catch up the subcommand changes
https://github.com/redis/redis/runs/5060123712?check_suite_focus=true#step:9:616

00:42:36> ADDSLOTSRANGE command with several boundary conditions test suite: FAILED: Expected 'ERR wrong number
 of arguments for 'cluster|addslotsrange' command' to match 'ERR wrong number of arguments for 'addslotsrange' 
command' (context: type source line 87 file /home/runner/work/redis/redis/tests/support/test.tcl cmd {assert_match 
$pattern $error} proc ::assert_error level 1)

oranagra pushed a commit that referenced this pull request Feb 4, 2022
@enjoy-binbin
Fix cluster tests failing due to subcommand names (#10231)
d2fde2f 
Introduced in #10128
@hwware hwware deleted the cluster-test branch February 4, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra Awaiting requested review from oranagra

1 more reviewer

@madolson madolson madolson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hwware @enjoy-binbin @madolson