New detailed key-spec flags (RO, RW, OW, RM, ACCESS, UPDATE, INSERT, DELETE)#10122
Merged
oranagra merged 5 commits intoredis:unstablefrom Jan 18, 2022
oranagra:key-spec-mess
Merged
New detailed key-spec flags (RO, RW, OW, RM, ACCESS, UPDATE, INSERT, DELETE)#10122oranagra merged 5 commits intoredis:unstablefrom oranagra:key-spec-mess
oranagra merged 5 commits intoredis:unstablefrom
oranagra:key-spec-mess
Conversation
Member
Author
|
sundb
reviewed
Jan 17, 2022
Member
Author
|
update
PFADD and SMOVE already used INSERT rather than UPDATE |
Collaborator
|
Should |
Member
Author
|
yes.. all "POP"s should use delete. i did mark some that way, but not others. |
Member
Author
|
update:
|
itamarhaber
approved these changes
Jan 18, 2022
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jan 19, 2022
In redis#10122, we modify the key spec flags to `RO` and `ACCESS`. But forgot to call generate-command-code.py. Also formatted it to follow the Python PEP8.
oranagra
pushed a commit
that referenced
this pull request
Jan 19, 2022
In #10122, we modify the key spec flags to `RO` and `ACCESS`. But forgot to call generate-command-code.py. Also formatted it to follow the Python PEP8.
5 tasks
roggervalf
pushed a commit
to roggervalf/redis
that referenced
this pull request
Feb 11, 2024
…command (redis#12917) In redis#10122, we set the destination key's flag of SINTERSTORE to `RW`, however, this command doesn't actually read or modify the destination key, just overwrites it. Therefore, we change it to `OW` similarly to all other *STORE commands.
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
…command (redis#12917) In redis#10122, we set the destination key's flag of SINTERSTORE to `RW`, however, this command doesn't actually read or modify the destination key, just overwrites it. Therefore, we change it to `OW` similarly to all other *STORE commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new ACL key based permissions in #9974 require the key-specs (#8324) to have more explicit flags rather than just READ and WRITE. See discussion in #10040
This PR defines two groups of flags:
One about how redis internally handles the key (mutually-exclusive).
The other is about the logical operation done from the user's point of view (3 mutually exclusive write flags, and one read flag, all optional).
In both groups, if we can't explicitly flag something as explicit read-only, delete-only, or insert-only, we flag it as
RWorUPDATE.here's the definition from the code:
Unrelated changes:
shard_channelkey-spec flag to justchannel.