show sub-commands INFO latencystats and LATENCY HISTOGRAM#10103
Merged
oranagra merged 6 commits intoredis:unstablefrom Jan 17, 2022
Merged
show sub-commands INFO latencystats and LATENCY HISTOGRAM#10103oranagra merged 6 commits intoredis:unstablefrom
oranagra merged 6 commits intoredis:unstablefrom
Conversation
filipecosta90
added
the
action:run-benchmark
Member
|
we also need to modify |
Contributor
Author
OK, and |
oranagra
reviewed
Jan 12, 2022
oranagra
approved these changes
Jan 14, 2022
1 task
sorry.. i didn't like the fact latency_histogram just took the second element without matching the name of the command (first list element). i didn't like the fact we repeadadly call the same command to validate different things on the same output. (this also messed up the count when trying to validate the count) adding validation of the sub-command name when calling the unfiltered LATENCYH HISTOGRAM
Member
|
@filipecosta90 @soloestoy FYI see the test cleanup i did in 466bf66 (converting the response to a dict and doing explicit lookups) |
oranagra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since
info commandstatsalready shows sub-commands, we should do the same ininfo latencystats.similarly, the LATENCY HISTOGRAM command now shows sub-commands (with their full name) when: