Skip to content

Bug in redis-check-dump.c  #709

@boaz0

Description

@boaz0

Scenario walk-through:

  1. compile redis, run the server, and connect to the server using redis-cli.
  2. type the following commands:
    hset myhash myhashname "first redis hash"
    bgsave
  3. run redis check dump on the dump.rdb that has just been created
  4. receiving the following output
    ==== Processed 0 valid opcodes (in 0 bytes) ====================================
    ==== Error trace (SELECTDB) ====================================================
    0x0000000b - Followed by invalid type
    0x00000009 - Error for type SELECTDB
    ==== Processed 0 valid opcodes (in 0 bytes) ====================================
    ==== Error trace ===============================================================
    0x0000003b - Expected EOF, got
    CRC64 checksum is OK

I guess the cause of these errors is related to not considering the hash zip list object type as a valid object type.
You can see how I have "fixed" it on my forked repository:
https://github.com/ripcurld00d/redis/commit/24c7386c401dd92f98781ab0e3ae9bc0516a790b

Although, I am not sure if that is the correct way to solve the problem.

Thanks in advance. :)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions