fix hincrbyfloat not to create a key if the new value is invalid (#11149)

chendq8 · oranagra · chendianqiang · oranagra · commit 7df23a5f5148 · 2023-04-13T14:36:34.000+03:00
Check the validity of the value before performing the create operation, prevents new data from being generated even if the request fails to execute. Co-authored-by: Oran Agra <oran@redislabs.com> Co-authored-by: chendianqiang <chendianqiang@meituan.com> Co-authored-by: Binbin <binloveplay1314@qq.com> (cherry picked from commit bc7fe41) (cherry picked from commit 606a385)
diff --git a/src/t_hash.c b/src/t_hash.c
@@ -729,6 +729,10 @@ void hincrbyfloatCommand(client *c) {
     unsigned int vlen;
 
     if (getLongDoubleFromObjectOrReply(c,c->argv[3],&incr,NULL) != C_OK) return;
+    if (isnan(incr) || isinf(incr)) {
+        addReplyError(c,"value is NaN or Infinity");
+        return;
+    }
     if ((o = hashTypeLookupWriteOrCreate(c,c->argv[1])) == NULL) return;
     if (hashTypeGetValue(o,c->argv[2]->ptr,&vstr,&vlen,&ll) == C_OK) {
         if (vstr) {
diff --git a/tests/unit/type/hash.tcl b/tests/unit/type/hash.tcl
@@ -801,4 +801,8 @@ start_server {tags {"hash"}} {
         set _ $k
     } {ZIP_INT_8B 127 ZIP_INT_16B 32767 ZIP_INT_32B 2147483647 ZIP_INT_64B 9223372036854775808 ZIP_INT_IMM_MIN 0 ZIP_INT_IMM_MAX 12}
 
+    test {HINCRBYFLOAT does not allow NaN or Infinity} {
+        assert_error "*value is NaN or Infinity*" {r hincrbyfloat hfoo field +inf}
+        assert_equal 0 [r exists hfoo]
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -801,4 +801,8 @@ start_server {tags {"hash"}} {`
`801`	`801`	`set _ $k`
`802`	`802`	`} {ZIP_INT_8B 127 ZIP_INT_16B 32767 ZIP_INT_32B 2147483647 ZIP_INT_64B 9223372036854775808 ZIP_INT_IMM_MIN 0 ZIP_INT_IMM_MAX 12}`
`803`	`803`
	`804`	`+ test {HINCRBYFLOAT does not allow NaN or Infinity} {`
	`805`	`+ assert_error "value is NaN or Infinity" {r hincrbyfloat hfoo field +inf}`
	`806`	`+ assert_equal 0 [r exists hfoo]`
	`807`	`+ }`
`804`	`808`	`}`