fix(ssubscribe): properly resubscribe in case of shard failover#3098
Merged
nkaradzhov merged 2 commits intoredis:masterfrom Oct 13, 2025
Merged
fix(ssubscribe): properly resubscribe in case of shard failover#3098nkaradzhov merged 2 commits intoredis:masterfrom
nkaradzhov merged 2 commits intoredis:masterfrom
Conversation
Collaborator
nkaradzhov
commented
Oct 9, 2025
nkaradzhov
commented
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
ff426bc to
2a766b7
Compare
Collaborator
Author
|
run sharded pub sub tests |
Contributor
|
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
2a766b7 to
b07e39b
Compare
Collaborator
Author
|
run sharded pub sub tests |
… TODO cleanup debug logs 1) when RE failover happens, there is a disconnect 2) affected Client reconnects and tries to resubscribe all existing listeners ISSUE #1: CROSSSLOT Error - client was doing ssubscribe ch1 ch2.. chN which, after the failover could result in CROSSSLOT ( naturally, becasuse now some slots could be owned by other shards ) FIX: send one ssubscribe command per channel instead of one ssubscribe for all channels ISSUE #2: MOVED Error - some/all of the channels might be moved somewhere else FIX: 1: propagate the error to the Cluster. 2: Cluster rediscovers topology. 3: Extract all existing subscriptions from all pubsub clients and resubscribe over the new topology. fixes: redis#2902
Contributor
|
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
b07e39b to
4423777
Compare
PR Reviewer Guide 🔍
|
bobymicroby
reviewed
Oct 10, 2025
Collaborator
Author
|
run sharded pub sub tests |
Contributor
|
Collaborator
Author
|
run sharded pub sub tests |
Contributor
|
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
113229c to
697402f
Compare
Collaborator
Author
|
run sharded pub sub tests |
Contributor
|
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
697402f to
6187101
Compare
nkaradzhov
force-pushed
the
cluster-failover-issue
branch
from
6187101 to
9bf5f7b
Compare
Collaborator
Author
|
run sharded pub sub tests |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.