hScanValuesIterator yields field names instead of values #3343

RedisClient.hScanValuesIterator() is meant to stream a hash's values — the values-only counterpart to hScanIterator (which yields { field, value } entries) and hScanNoValuesIterator (which yields field names).

However, its body is a copy of hScanNoValuesIterator: it calls hScanNoValues() — which issues HSCAN ... NOVALUES, a reply that by protocol contains only field names — and then yields reply.fields. As a result it returns hash field names, byte-for-byte identical to hScanNoValuesIterator, and can never return values.

https://github.com/redis/node-redis/blob/master/packages/client/lib/client/index.ts#L1690-L1701

Reproduction

For a hash { f1: 'v1', f2: 'v2' }:

for await (const values of client.hScanValuesIterator('myhash')) {
  console.log(values);
}
// observed: [ 'f1', 'f2' ]   (field names)
// expected: [ 'v1', 'v2' ]   (values)

Fix

Iterate the full HSCAN (as hScanIterator already does) and yield the values:

async *hScanValuesIterator(this, key, options) {
  let cursor = options?.cursor ?? '0';
  do {
    const reply = await this.hScan(key, cursor, options);
    cursor = reply.cursor;
    yield reply.entries.map(entry => entry.value);
  } while (cursor !== '0');
}

I'll open a PR with this fix.