ISSUE#3328 - Remove deprecated code from ISSUE#1314#3351
Merged
tishun merged 1 commit intoredis:mainfrom Aug 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up deprecated bufferUsageRatio methods and related code in favor of the newer DecodeBufferPolicy.
- Removed
bufferUsageRatio(int)builder method fromClientOptions.Builder - Removed
getBufferUsageRatio()getter method fromClientOptions - Removed overridden
bufferUsageRatio(int)inClusterClientOptions.Builder
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/io/lettuce/core/ClientOptions.java | Deleted deprecated bufferUsageRatio builder and getter |
| src/main/java/io/lettuce/core/cluster/ClusterClientOptions.java | Deleted overridden deprecated bufferUsageRatio builder |
tishun
approved these changes
Jul 11, 2025
Collaborator
tishun
left a comment
tishun
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR! ;)
17 tasks
tishun
force-pushed
the
issue#3328/clean-deprecated-code-from#1314
branch
from
7be29f2 to
e824d86
Compare
tishun
force-pushed
the
issue#3328/clean-deprecated-code-from#1314
branch
from
e824d86 to
0760614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated bufferUsageRatio methods
Removes deprecated
bufferUsageRatiomethods and related code fromClientOptionsandClusterClientOptionsclasses.Changes
bufferUsageRatio(int)builder method fromClientOptions.BuildergetBufferUsageRatio()getter method fromClientOptionsbufferUsageRatio(int)method fromClusterClientOptions.BuilderThese methods were deprecated in version 6.0 in favor of
DecodeBufferPolicy(issue #1314) and are now being cleaned up.Related Issues