chore: remove deprecated ClientOptions#cancelCommandsOnReconnectFailure (#3328)#3346
Merged
tishun merged 2 commits intoredis:mainfrom Aug 8, 2025
Conversation
- removed the option from ClientOptions and ClusterClientOptions and related builders - removed usages from integration tests and unit tests - removed usage from ReconnectionHandler and DefaultEndpoint Signed-off-by: The-East-Wind <[email protected]>
tishun
approved these changes
Jul 7, 2025
Collaborator
tishun
left a comment
tishun
left a comment
There was a problem hiding this comment.
Awesome work, thanks for the contribution!
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Partially resolves #3328
Follow up to #1787
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.