Hey @The-East-Wind , which of the tasks in #3328 does this PR address?

@tishun This aims to partially address follow up to https://github.com/redis/lettuce/issues/2028 clean up the connection-related APIs, e.g. BaseRedisCommands. If the approach I've taken is acceptable I'll follow the same and complete it.

Hey @The-East-Wind ,

yes, I think this is the correct approach. Do you have something specific that you are concerned about?

@tishun the number of places which required change was high so I wanted to confirm I was following the right approach before make all the changes so that there is no rework. I was specifically concerned about using try-with-resource for closing connections instead of explicitly calling close as throughout the tests explicit close calls were used instead of try-with-resource.

@tishun the number of places which required change was high so I wanted to confirm I was following the right approach before make all the changes so that there is no rework. I was specifically concerned about using try-with-resource for closing connections instead of explicitly calling close as throughout the tests explicit close calls were used instead of try-with-resource.

Sorry, saw your comment just now. What you did was great work, thanks a bunch!

try-with-resources could be used anywhere, my speculation is that it was not used because the codebase is old and there were times when it was not available as a construct.