Skip to content

DefaultClientResources.dnsResolver(DnsResolver resolver) should be marked as deprecated. #2854

Closed
#2855
Closed
DefaultClientResources.dnsResolver(DnsResolver resolver) should be marked as deprecated.#2854
#2855
@yfwz100

Description

@yfwz100
yfwz100
opened on May 14, 2024

Just like definitions at its interface:

lettuce/src/main/java/io/lettuce/core/resource/ClientResources.java

Lines 164 to 175 in cc9d240

/**
* Sets the {@link DnsResolver} that is used to resolve hostnames to {@link java.net.InetAddress}. Defaults to
* {@link DnsResolvers#UNRESOLVED} to use netty's {@link AddressResolverGroup}.
*
* @param dnsResolver the DNS resolver, must not be {@code null}.
* @return {@code this} {@link Builder}.
* @since 4.3
* @deprecated since 6.1. Configure {@link AddressResolverGroup} instead.
*/
@Deprecated
Builder dnsResolver(DnsResolver dnsResolver);

The implementation method should be marked as deprecated to inform users to use the new settings.

lettuce/src/main/java/io/lettuce/core/resource/DefaultClientResources.java

Line 452 in cc9d240

public Builder dnsResolver(DnsResolver dnsResolver) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions