Refactor tests for clarity and maintainability (#3363)

Rian-Ismael · web-flow · commit 2a7d2a40de32 · 2025-08-01T11:22:18.000+03:00
* test: remove redundant assertions and clarify time-related values with constants

* test: remove redundant assertions and clarify time-related values with constants

* test: remove redundant assertions and clarify time-related values with constants
diff --git a/src/test/java/io/lettuce/core/TimeoutOptionsUnitTests.java b/src/test/java/io/lettuce/core/TimeoutOptionsUnitTests.java
@@ -38,13 +38,15 @@ void defaultConnectionTimeout() {
 
     @Test
     void fixedConnectionTimeout() {
+        final long MINUTES = 1;
+        final long MINUTE_IN_NANOS = TimeUnit.MINUTES.toNanos(MINUTES);
 
-        TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(1));
+        TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(MINUTES));
 
         TimeoutSource source = timeoutOptions.getSource();
         assertThat(timeoutOptions.isTimeoutCommands()).isTrue();
         assertThat(timeoutOptions.isApplyConnectionTimeout()).isFalse();
-        assertThat(source.getTimeout(null)).isEqualTo(TimeUnit.MINUTES.toNanos(1));
+        assertThat(source.getTimeout(null)).isEqualTo(MINUTE_IN_NANOS);
     }
 
 }
diff --git a/src/test/java/io/lettuce/core/sentinel/SentinelServerCommandIntegrationTests.java b/src/test/java/io/lettuce/core/sentinel/SentinelServerCommandIntegrationTests.java
@@ -80,10 +80,18 @@ void after() {
     }
 
     @Test
-    public void clientGetSetname() {
+    public void clientGetNameReturnsNullWhenNotSet() {
         assertThat(sentinel.clientGetname()).isNull();
+    }
+
+    @Test
+    public void clientSetNameWithNonEmptyStringSetsNameAndReturnsOk() {
         assertThat(sentinel.clientSetname("test")).isEqualTo("OK");
         assertThat(sentinel.clientGetname()).isEqualTo("test");
+    }
+
+    @Test
+    public void clientSetNameWithEmptyStringClearsNameAndReturnsOk() {
         assertThat(sentinel.clientSetname("")).isEqualTo("OK");
         assertThat(sentinel.clientGetname()).isNull();
     }

Original file line number	Diff line number	Diff line change
`@@ -38,13 +38,15 @@ void defaultConnectionTimeout() {`
`38`	`38`
`39`	`39`	`@Test`
`40`	`40`	`void fixedConnectionTimeout() {`
	`41`	`+ final long MINUTES = 1;`
	`42`	`+ final long MINUTE_IN_NANOS = TimeUnit.MINUTES.toNanos(MINUTES);`
`41`	`43`
`42`		`- TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(1));`
	`44`	`+ TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(MINUTES));`
`43`	`45`
`44`	`46`	`TimeoutSource source = timeoutOptions.getSource();`
`45`	`47`	`assertThat(timeoutOptions.isTimeoutCommands()).isTrue();`
`46`	`48`	`assertThat(timeoutOptions.isApplyConnectionTimeout()).isFalse();`
`47`		`- assertThat(source.getTimeout(null)).isEqualTo(TimeUnit.MINUTES.toNanos(1));`
	`49`	`+ assertThat(source.getTimeout(null)).isEqualTo(MINUTE_IN_NANOS);`
`48`	`50`	`}`
`49`	`51`
`50`	`52`	`}`