Skip to content

Remove unused leftovers from JedisSharding#4348

Merged
ggivo merged 5 commits intomasterfrom
im/remove-leftovers-from-sharding
Mar 18, 2026
Merged

Remove unused leftovers from JedisSharding#4348
ggivo merged 5 commits intomasterfrom
im/remove-leftovers-from-sharding

Conversation

@uglide
Copy link
Copy Markdown
Contributor

@uglide uglide commented Nov 5, 2025 •
edited by cursor bot
Loading

Continuation of #4311

Note

Low Risk
Low risk cleanup removing deprecated, apparently unreferenced sharding hashing utilities and a benchmark. Main risk is for any downstream consumers relying on these internal classes, but no in-repo usages remain.

Overview
Removes deprecated sharding leftovers by deleting the Hashing interface (including its MD5 implementation) and the MurmurHash implementation.

Also deletes the HashingBenchmark test/benchmark that exercised these hashing functions.

Written by Cursor Bugbot for commit f42f0f8. This will update automatically on new commits. Configure here.

@uglide uglide requested a review from ggivo November 5, 2025 08:58
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2025 •
edited
Loading

Test Results

   305 files  ± 0    305 suites  ±0   8m 54s ⏱️ - 2m 46s
10 913 tests  - 31  9 222 ✅  - 1 507  1 691 💤 +1 476  0 ❌ ±0 
 5 622 runs   - 37  5 026 ✅  -   566    596 💤 +  529  0 ❌ ±0 

Results for commit f42f0f8. ± Comparison against base commit df7a9f4.

This pull request removes 32 and adds 1 tests. Note that renamed tests count towards both. 
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[1]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[2]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[3]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[4]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[5]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[6]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[7]
redis.clients.jedis.csc.RedisSentinelClientSideCacheTest ‑ advancedPubsubWithClientCache
redis.clients.jedis.csc.RedisSentinelClientSideCacheTest ‑ cacheNotEmptyTest
redis.clients.jedis.csc.RedisSentinelClientSideCacheTest ‑ cacheUsedTest
…

redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)
This pull request skips 1475 tests. 
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hexpireAndHttl
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hexpireAndHttlBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hexpireAtAndExpireTime
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hexpireAtAndExpireTimeBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpersist
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpersistBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpexpireAndHpttl
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpexpireAndHpttlBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpexpireAtAndPexpireTime
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ hpexpireAtAndPexpireTimeBinary
…

♻️ This comment has been updated with latest results.

@ggivo ggivo added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Nov 5, 2025
@uglide
Copy link
Copy Markdown
Contributor Author

uglide commented Nov 5, 2025

@ggivo I don't think it's a breaking change, since the files are internal and not used extrernaly.

@ggivo
Copy link
Copy Markdown
Collaborator

ggivo commented Nov 6, 2025

@uglide
What do you mean by not used externaly?
They are marked @deprecated but are public and not documented as internal in comments or annotated with @internal.

@uglide
Copy link
Copy Markdown
Contributor Author

uglide commented Nov 6, 2025

@ggivo see https://github.com/redis/jedis/pull/4311/files#diff-a1c95bbe6e3dc70afb41f29448973d7f61021891667a064b67d5bbc2603748b3L32-L35
This PR removes leftovers that were overseen during the JedisSharding removal. Hashing was used only for JedisSharding and is unlikely to be used without it.

@ggivo ggivo added this to the 8.0.0 milestone Dec 6, 2025
@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Mar 16, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR

Security scan by Jit

@ggivo ggivo merged commit d9b979c into master Mar 18, 2026
21 of 22 checks passed
@ggivo ggivo deleted the im/remove-leftovers-from-sharding branch March 24, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggivo ggivo ggivo approved these changes

Assignees

No one assigned

Labels

breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@uglide @ggivo