Remove broken JSON.ARRAPPEND method from CommandObjects#3795
Closed
gerzse wants to merge 1 commit intoredis:masterfrom
Closed
Remove broken JSON.ARRAPPEND method from CommandObjects#3795gerzse wants to merge 1 commit intoredis:masterfrom
gerzse wants to merge 1 commit intoredis:masterfrom
Conversation
One of the jsonArrAppend methods in CommandObjects has broken serialization. Instead of deserializing the response into a List<Long>, it's only expecting Long. Luckily this method is not used, so better remove it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3795 +/- ##
============================================
+ Coverage 79.61% 79.68% +0.06%
- Complexity 5701 5705 +4
============================================
Files 301 301
Lines 15273 15269 -4
Branches 1190 1189 -1
============================================
+ Hits 12160 12167 +7
+ Misses 2532 2525 -7
+ Partials 581 577 -4 ☔ View full report in Codecov by Sentry. |
sazzad16
added
breakingchange
sazzad16
previously approved these changes
Apr 3, 2024
sazzad16
reviewed
Apr 3, 2024
Contributor
sazzad16
left a comment
sazzad16
left a comment
There was a problem hiding this comment.
It's not broken. RedisJSON v1 returns a Long in this case.
RedisJSON v1 support is already deprecated. So deprecating this method is the safest approach IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the jsonArrAppend methods in CommandObjects has broken serialization. Instead of deserializing the response into a List, it's only expecting Long. Luckily this method is not used, so better remove it.