Support white-list and black-list commands and keys#3740
Support white-list and black-list commands and keys#3740sazzad16 wants to merge 12 commits intoredis:5.2.0from
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 5.2.0 #3740 +/- ##
============================================
- Coverage 75.54% 75.10% -0.44%
+ Complexity 4984 4981 -3
============================================
Files 300 303 +3
Lines 15241 15261 +20
Branches 1157 1163 +6
============================================
- Hits 11514 11462 -52
- Misses 3221 3286 +65
- Partials 506 513 +7 ☔ View full report in Codecov by Sentry. |
|
Should we use allow-list and deny-list? |
gerzse
left a comment
gerzse
left a comment
There was a problem hiding this comment.
LGTM, just some naming related commends.
| } | ||
|
|
||
| @Override | ||
| public boolean isCacheable(ProtocolCommand command, Object... keys) { |
There was a problem hiding this comment.
Given that there is a default in the interface, this is not needed.
| private static final Integer ZERO_INTEGER = 0; | ||
|
|
||
| public static ClientSideCache getClientSideCache(URI uri) { | ||
| public static ClientSideCacheConfig getClientSideCache(URI uri) { |
There was a problem hiding this comment.
Maybe add a new argument, a cache config builder? Can be Function<ClientSideCache, ClientSideCacheConfig>. That might be a breaking change, so it can be a new method, to have an alternative.
|
@sazzad16 LGTM. |
5 participants
cscpackage