Added java code snippet for hyperloglog#3674
Merged
sazzad16 merged 6 commits intoredis:emb-examplesfrom Jan 13, 2024
Merged
Conversation
Contributor
Author
|
Hi @dwdougherty Please review this example |
dwdougherty
approved these changes
Jan 2, 2024
Contributor
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
LGTM. Thanks again, Ranjeet!
sazzad16
reviewed
Jan 2, 2024
Contributor
sazzad16
left a comment
sazzad16
left a comment
There was a problem hiding this comment.
@dwdougherty Weren't the imports supposed to be removed or at least hidden?
@Ranjeet0611 Here is only one object of UnifiedJedis. So use a shorter variable name; like jedis, client, etc.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## emb-examples #3674 +/- ##
===============================================
Coverage ? 75.36%
Complexity ? 4894
===============================================
Files ? 297
Lines ? 14965
Branches ? 1129
===============================================
Hits ? 11278
Misses ? 3192
Partials ? 495 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@sazzad16 did the changes |
Contributor
Only the code between |
sazzad16
suggested changes
Jan 2, 2024
Contributor
Author
|
@dwdougherty please review |
dwdougherty
approved these changes
Jan 12, 2024
Contributor
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
@sazzad16 This PR builds correctly and it's good to go.
sazzad16
approved these changes
Jan 13, 2024
uglide
added a commit
that referenced
this pull request
Jun 18, 2024
* Fix search_quickstart example * Add data_class step to SearchQuickstartExample * Update examples with new bikes and align to new tutorial * Fixes doctests for search tutorial * Small fixes doctests * Updates search tutorial doc examples to new format and data * Fix formatting in doc tests * Add Hashes and String Example (#3477) * Add Hashes Example * Fixes examples for hash tutorial * Refactor Hash Tutorial to Java 8 (from 17) * Change indentation to 4 spaces * Add Strings Example * Reformat samples to 2-space indentation --------- Co-authored-by: Elena Kolevska <[email protected]> * Add Geospatial data type example (#3487) * Add Geospatial data type example * Add missing REMOVE_END * Added example Java code snippets for Streams (#3641) * Java example code snippets for T-Digest and TopK (#3660) * Created example for t digest * Added example for topK --------- Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: Ranjeet Singh <[email protected]> * Create Java code snippets for sets #3626 (#3661) * Create Java code snippets for sets #3626 * Apply suggestions from code review to add // STEP_END lines. Co-authored-by: David Dougherty <[email protected]> * format imports --------- Co-authored-by: David Dougherty <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> * Create Java code snippets for count min sketch (#3644) * added code snippet for CMS in Java * Update CMSExample.java * format spaces * use cmsIncrBy simple variant * more format spaces --------- Co-authored-by: M Sazzadul Hoque <[email protected]> * Added Java code snippets for Bloom #3630 (#3671) * Added java example for bloom filter * Removed space * fix and format imports * fix compile error * format spaces * Add del command and rename obj * Add del command and fix format * change to junit assert * Update BloomFilterExample.java * Add correct output comment --------- Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> Co-authored-by: Ranjeet Singh <[email protected]> * Added java code snippet for hyperloglog (#3674) * Added Java code snippet for HyperLogLog * fix format and imports * fix spaces * change to junit assert * Added correct output comment * Update HyperLogLogExample.java --------- Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> * Added Java code snippets for cuckoo filters (#3679) * Add CuckooFilterExample * Add step start comment * Update CuckooFilterExample.java --------- Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> * Create Java code snippet for lists #3625 (#3677) * Added example Java code snippets for the List#3625 * format spaces --------- Co-authored-by: M Sazzadul Hoque <[email protected]> * Create Java code snippet for sorted sets (#3680) * added an example for SortedSets in java * Update SortedSetsExample.java * made changes as per the review. * Format spaces in SortedSetsExample.java --------- Co-authored-by: M Sazzadul Hoque <[email protected]> * Added Java code snippet for bitmap (#3687) * Add bitmap example * Change class name * Add assert for res3 and res4 * Update BitMapsExample.java * Format spaces in BitMapsExample.java --------- Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> --------- Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Brian Sam-Bodden <[email protected]> Co-authored-by: M Sazzadul Hoque <[email protected]> Co-authored-by: Harshvardhan Parmar <[email protected]> Co-authored-by: Ranjeet SIngh <[email protected]> Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: Ranjeet Singh <[email protected]> Co-authored-by: Suraj <[email protected]> Co-authored-by: David Dougherty <[email protected]> Co-authored-by: Ranjeet Singh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added java code snippet for hyperloglog #3629