Skip to content

Fix tests#2762

Merged
chayim merged 2 commits intoredis:masterfrom
AvitalFineRedis:flakyTests
Dec 23, 2021
Merged

Fix tests#2762
chayim merged 2 commits intoredis:masterfrom
AvitalFineRedis:flakyTests

Conversation

@AvitalFineRedis
Copy link
Copy Markdown
Contributor

@AvitalFineRedis AvitalFineRedis commented Dec 23, 2021

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #2762 (35b85d6) into master (301ab08) will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2762      +/-   ##
============================================
- Coverage     57.82%   57.37%   -0.46%     
+ Complexity     2822     2780      -42     
============================================
  Files           168      168              
  Lines         10331    10331              
  Branches        599      599              
============================================
- Hits           5974     5927      -47     
- Misses         4146     4197      +51     
+ Partials        211      207       -4
Impacted Files Coverage Δ
...dis/clients/jedis/commands/HashBinaryCommands.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/redis/clients/jedis/ClusterCommandObjects.java 17.85% <0.00%> (-25.00%) ⬇️
...rc/main/java/redis/clients/jedis/JedisCluster.java 23.94% <0.00%> (-8.46%) ⬇️
...in/java/redis/clients/jedis/params/ScanParams.java 71.42% <0.00%> (-4.77%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 63.25% <0.00%> (-4.69%) ⬇️
...nts/jedis/providers/ClusterConnectionProvider.java 72.72% <0.00%> (-1.82%) ⬇️
src/main/java/redis/clients/jedis/Connection.java 83.83% <0.00%> (-1.52%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 88.31% <0.00%> (+1.29%) ⬆️
...in/java/redis/clients/jedis/ConnectionFactory.java 67.34% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301ab08...35b85d6. Read the comment docs.

@chayim chayim self-requested a review December 23, 2021 08:25
@chayim
Copy link
Copy Markdown
Contributor

chayim commented Dec 23, 2021

@AvitalFineRedis rather than delete the flaky tests what do you think of disabling them somehow? This way, they can be analyzed and possibly reused in the future.

@AvitalFineRedis
Copy link
Copy Markdown
Contributor Author

AvitalFineRedis commented Dec 23, 2021

@AvitalFineRedis rather than delete the flaky tests what do you think of disabling them somehow? This way, they can be analyzed and possibly reused in the future.

fixed

@sazzad16
Copy link
Copy Markdown
Contributor

sazzad16 commented Dec 23, 2021

@AvitalFineRedis JUnit has @Ignore annotation. You can put that before each test class declaration.

@chayim chayim merged commit 4c61eee into redis:master Dec 23, 2021
@sazzad16 sazzad16 modified the milestone: 4.1.0 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chayim chayim chayim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AvitalFineRedis @codecov-commenter @chayim @sazzad16