Expected behavior
When a connection is evicted in JedisPool, this is done quietly in the background.
Actual behavior
While it seems the eviction is working correctly—via the Apache commons-pool library—the Jedis library logs an ERROR level log when determining the connection is no longer valid.
Steps to reproduce:
To reproduce, you need to have your pool connected and simulate an 'invalid' connection by having the server drop the connection to the Jedis client pool.
Suggested change:
Because it is expected that the connection may no longer be valid, I suggest we log a WARN instead of an ERROR. I've made a small PR that makes that change here: #3747
Expected behavior
When a connection is evicted in
JedisPool, this is done quietly in the background.Actual behavior
While it seems the eviction is working correctly—via the Apache commons-pool library—the Jedis library logs an ERROR level log when determining the connection is no longer valid.
Steps to reproduce:
To reproduce, you need to have your pool connected and simulate an 'invalid' connection by having the server drop the connection to the Jedis client pool.
Suggested change:
Because it is expected that the connection may no longer be valid, I suggest we log a WARN instead of an ERROR. I've made a small PR that makes that change here: #3747