address co-pilot review comments

ggivo · ggivo · commit 38fa2a5593bf · 2026-04-01T15:23:57.000+03:00
diff --git a/src/main/java/redis/clients/jedis/JedisCluster.java b/src/main/java/redis/clients/jedis/JedisCluster.java
@@ -430,7 +430,7 @@ public void ssubscribe(BinaryJedisShardedPubSub jedisPubSub, final byte[]... cha
    *
    * <p>If the pipeline spans multiple nodes, a dedicated {@link ExecutorService} is
    * created internally to execute requests in parallel and shutdown when the pipeline
-   * is closed.</p>
+   * is synced.</p>
    *
    * @return a new {@link ClusterPipeline} instance
    * @see #pipelined(ExecutorService)
diff --git a/src/main/java/redis/clients/jedis/MultiNodePipelineBase.java b/src/main/java/redis/clients/jedis/MultiNodePipelineBase.java
@@ -11,8 +11,6 @@
 import java.util.concurrent.Executor;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
-import java.util.concurrent.ThreadFactory;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
diff --git a/src/main/java/redis/clients/jedis/RedisClusterClient.java b/src/main/java/redis/clients/jedis/RedisClusterClient.java
@@ -200,7 +200,7 @@ public void ssubscribe(BinaryJedisShardedPubSub jedisPubSub, final byte[]... cha
    *
    * <p>If the pipeline spans multiple nodes, a dedicated {@link ExecutorService} is
    * created internally to execute requests in parallel and shutdown when the pipeline
-   * is closed.</p>
+   * is synced.</p>
    *
    * @return a new {@link ClusterPipeline} instance
    * @see #pipelined(ExecutorService)
diff --git a/src/test/java/redis/clients/jedis/ClusterPipeliningTest.java b/src/test/java/redis/clients/jedis/ClusterPipeliningTest.java
@@ -1266,7 +1266,10 @@ public void sharedExecutorPipelineDoesNotShutdownSharedExecutor() {
     ExecutorService executorService = Executors.newFixedThreadPool(3);
     try ( RedisClusterClient cluster = RedisClusterClient.builder().nodes(nodes).clientConfig(DEFAULT_CLIENT_CONFIG).build()){
       try (ClusterPipeline pipeline = cluster.pipelined(executorService)) {
-        pipeline.set("key", "value");
+        // multiple keys at different slots, to ensure multi-node pipeline
+        pipeline.set("key1", "value1");
+        pipeline.set("key2", "value2");
+        pipeline.set("key3", "value3");
         pipeline.sync();
       }
     } finally {

Original file line number	Diff line number	Diff line change
`@@ -430,7 +430,7 @@ public void ssubscribe(BinaryJedisShardedPubSub jedisPubSub, final byte[]... cha`
`430`	`430`	`*`
`431`	`431`	`* <p>If the pipeline spans multiple nodes, a dedicated {@link ExecutorService} is`
`432`	`432`	`* created internally to execute requests in parallel and shutdown when the pipeline`
`433`		`- * is closed.</p>`
	`433`	`+ * is synced.</p>`
`434`	`434`	`*`
`435`	`435`	`* @return a new {@link ClusterPipeline} instance`
`436`	`436`	`* @see #pipelined(ExecutorService)`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ public void ssubscribe(BinaryJedisShardedPubSub jedisPubSub, final byte[]... cha`
`200`	`200`	`*`
`201`	`201`	`* <p>If the pipeline spans multiple nodes, a dedicated {@link ExecutorService} is`
`202`	`202`	`* created internally to execute requests in parallel and shutdown when the pipeline`
`203`		`- * is closed.</p>`
	`203`	`+ * is synced.</p>`
`204`	`204`	`*`
`205`	`205`	`* @return a new {@link ClusterPipeline} instance`
`206`	`206`	`* @see #pipelined(ExecutorService)`