Skip to content

Commit 2d8193b

Browse files
sazzad16sazzad16
committed
GETSET command is deprecated since Redis 6.2.0
1 parent 7515d5a commit 2d8193b

8 files changed

Lines changed: 60 additions & 4 deletions

File tree

‎src/main/java/redis/clients/jedis/CommandObjects.java‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,8 @@ public final CommandObject<String> setGet(String key, String value) {
447447
}
448448

449449
public final CommandObject<String> setGet(String key, String value, SetParams params) {
450-
return new CommandObject<>(commandArguments(Command.SET).key(key).add(value).addParams(params)
451-
.add(Keyword.GET), BuilderFactory.STRING);
450+
return new CommandObject<>(commandArguments(Command.SET).key(key).add(value).addParams(params).add(Keyword.GET),
451+
BuilderFactory.STRING);
452452
}
453453

454454
public final CommandObject<String> getDel(String key) {
@@ -468,8 +468,8 @@ public final CommandObject<byte[]> setGet(byte[] key, byte[] value) {
468468
}
469469

470470
public final CommandObject<byte[]> setGet(byte[] key, byte[] value, SetParams params) {
471-
return new CommandObject<>(commandArguments(Command.SET).key(key).add(value).addParams(params)
472-
.add(Keyword.GET), BuilderFactory.BINARY);
471+
return new CommandObject<>(commandArguments(Command.SET).key(key).add(value).addParams(params).add(Keyword.GET),
472+
BuilderFactory.BINARY);
473473
}
474474

475475
public final CommandObject<byte[]> getDel(byte[] key) {
@@ -480,10 +480,18 @@ public final CommandObject<byte[]> getEx(byte[] key, GetExParams params) {
480480
return new CommandObject<>(commandArguments(Command.GETEX).key(key).addParams(params), BuilderFactory.BINARY);
481481
}
482482

483+
/**
484+
* @deprecated Use {@link CommandObjects#setGet(java.lang.String, java.lang.String)}.
485+
*/
486+
@Deprecated
483487
public final CommandObject<String> getSet(String key, String value) {
484488
return new CommandObject<>(commandArguments(Command.GETSET).key(key).add(value), BuilderFactory.STRING);
485489
}
486490

491+
/**
492+
* @deprecated Use {@link CommandObjects#setGet(byte[], byte[])}.
493+
*/
494+
@Deprecated
487495
public final CommandObject<byte[]> getSet(byte[] key, byte[] value) {
488496
return new CommandObject<>(commandArguments(Command.GETSET).key(key).add(value), BuilderFactory.BINARY);
489497
}

‎src/main/java/redis/clients/jedis/Jedis.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,9 @@ public long move(final byte[] key, final int dbIndex) {
871871
* @param key
872872
* @param value
873873
* @return Bulk reply
874+
* @deprecated Use {@link Jedis#setGet(byte[], byte[])}.
874875
*/
876+
@Deprecated
875877
@Override
876878
public byte[] getSet(final byte[] key, final byte[] value) {
877879
checkIsInMultiOrPipeline();
@@ -5316,7 +5318,9 @@ public long move(final String key, final int dbIndex) {
53165318
* @param key
53175319
* @param value
53185320
* @return Bulk reply
5321+
* @deprecated Use {@link Jedis#setGet(java.lang.String, java.lang.String)}.
53195322
*/
5323+
@Deprecated
53205324
@Override
53215325
public String getSet(final String key, final String value) {
53225326
checkIsInMultiOrPipeline();

‎src/main/java/redis/clients/jedis/PipeliningBase.java‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ public Response<String> get(String key) {
280280
return appendCommand(commandObjects.get(key));
281281
}
282282

283+
@Override
284+
public Response<String> setGet(String key, String value) {
285+
return appendCommand(commandObjects.setGet(key, value));
286+
}
287+
283288
@Override
284289
public Response<String> setGet(String key, String value, SetParams params) {
285290
return appendCommand(commandObjects.setGet(key, value, params));
@@ -315,6 +320,10 @@ public Response<String> getrange(String key, long startOffset, long endOffset) {
315320
return appendCommand(commandObjects.getrange(key, startOffset, endOffset));
316321
}
317322

323+
/**
324+
* @deprecated Use {@link PipeliningBase#setGet(java.lang.String, java.lang.String)}.
325+
*/
326+
@Deprecated
318327
@Override
319328
public Response<String> getSet(String key, String value) {
320329
return appendCommand(commandObjects.getSet(key, value));
@@ -3114,6 +3123,11 @@ public Response<byte[]> get(byte[] key) {
31143123
return appendCommand(commandObjects.get(key));
31153124
}
31163125

3126+
@Override
3127+
public Response<byte[]> setGet(byte[] key, byte[] value) {
3128+
return appendCommand(commandObjects.setGet(key, value));
3129+
}
3130+
31173131
@Override
31183132
public Response<byte[]> setGet(byte[] key, byte[] value, SetParams params) {
31193133
return appendCommand(commandObjects.setGet(key, value, params));
@@ -3149,6 +3163,10 @@ public Response<byte[]> getrange(byte[] key, long startOffset, long endOffset) {
31493163
return appendCommand(commandObjects.getrange(key, startOffset, endOffset));
31503164
}
31513165

3166+
/**
3167+
* @deprecated Use {@link PipeliningBase#setGet(byte[], byte[])}.
3168+
*/
3169+
@Deprecated
31523170
@Override
31533171
public Response<byte[]> getSet(byte[] key, byte[] value) {
31543172
return appendCommand(commandObjects.getSet(key, value));

‎src/main/java/redis/clients/jedis/UnifiedJedis.java‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,10 @@ public byte[] getrange(byte[] key, long startOffset, long endOffset) {
825825
return executeCommand(commandObjects.getrange(key, startOffset, endOffset));
826826
}
827827

828+
/**
829+
* @deprecated Use {@link UnifiedJedis#setGet(java.lang.String, java.lang.String)}.
830+
*/
831+
@Deprecated
828832
@Override
829833
public String getSet(String key, String value) {
830834
return executeCommand(commandObjects.getSet(key, value));
@@ -845,6 +849,10 @@ public String psetex(String key, long milliseconds, String value) {
845849
return executeCommand(commandObjects.psetex(key, milliseconds, value));
846850
}
847851

852+
/**
853+
* @deprecated Use {@link UnifiedJedis#setGet(byte[], byte[])}.
854+
*/
855+
@Deprecated
848856
@Override
849857
public byte[] getSet(byte[] key, byte[] value) {
850858
return executeCommand(commandObjects.getSet(key, value));

‎src/main/java/redis/clients/jedis/commands/StringBinaryCommands.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ public interface StringBinaryCommands extends BitBinaryCommands {
2727

2828
byte[] getrange(byte[] key, long startOffset, long endOffset);
2929

30+
/**
31+
* @deprecated Use {@link StringBinaryCommands#setGet(byte[], byte[])}.
32+
*/
33+
@Deprecated
3034
byte[] getSet(byte[] key, byte[] value);
3135

3236
long setnx(byte[] key, byte[] value);

‎src/main/java/redis/clients/jedis/commands/StringCommands.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ public interface StringCommands extends BitCommands {
116116
* @param key
117117
* @param value
118118
* @return The old value that was stored in key
119+
* @deprecated Use {@link StringCommands#setGet(java.lang.String, java.lang.String)}.
119120
*/
121+
@Deprecated
120122
String getSet(String key, String value);
121123

122124
/**

‎src/main/java/redis/clients/jedis/commands/StringPipelineBinaryCommands.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ public interface StringPipelineBinaryCommands extends BitPipelineBinaryCommands
1616

1717
Response<byte[]> get(byte[] key);
1818

19+
Response<byte[]> setGet(byte[] key, byte[] value);
20+
1921
Response<byte[]> setGet(byte[] key, byte[] value, SetParams params);
2022

2123
Response<byte[]> getDel(byte[] key);
@@ -26,6 +28,10 @@ public interface StringPipelineBinaryCommands extends BitPipelineBinaryCommands
2628

2729
Response<byte[]> getrange(byte[] key, long startOffset, long endOffset);
2830

31+
/**
32+
* @deprecated {@link StringPipelineBinaryCommands#setGet(byte[], byte[], redis.clients.jedis.params.SetParams)}.
33+
*/
34+
@Deprecated
2935
Response<byte[]> getSet(byte[] key, byte[] value);
3036

3137
Response<Long> setnx(byte[] key, byte[] value);

‎src/main/java/redis/clients/jedis/commands/StringPipelineCommands.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ public interface StringPipelineCommands extends BitPipelineCommands {
1616

1717
Response<String> get(String key);
1818

19+
Response<String> setGet(String key, String value);
20+
1921
Response<String> setGet(String key, String value, SetParams params);
2022

2123
Response<String> getDel(String key);
@@ -26,6 +28,10 @@ public interface StringPipelineCommands extends BitPipelineCommands {
2628

2729
Response<String> getrange(String key, long startOffset, long endOffset);
2830

31+
/**
32+
* @deprecated Use {@link StringPipelineCommands#setGet(java.lang.String, java.lang.String)}.
33+
*/
34+
@Deprecated
2935
Response<String> getSet(String key, String value);
3036

3137
Response<Long> setnx(String key, String value);

0 commit comments

Comments
 (0)