replace context.TODO with context.WithTimeout in channel.initHealthCheck#3819
Merged
ndyakov merged 6 commits intoJun 17, 2026
Merged
Conversation
…eck before calling c.pubSub.Ping
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Member
|
Thank you @abdellani, Will review this as soon as possible. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 9f83adc. Configure here.
ndyakov
reviewed
Jun 10, 2026
ndyakov
approved these changes
Jun 15, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
Thank you @abdellani, looks good will double check and include tomorrow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #3811
Note
Medium Risk
Changes reconnect behavior under slow or stuck Redis/network by capping ping and reconnect duration; mis-tuned timeouts could trigger reconnects sooner than before, but defaults are reasonable for a background health loop.
Overview
Fixes #3811 by making the background PubSub channel health-check goroutine use bounded deadlines instead of an unbounded
context.TODO()for periodicPingand forreconnectafter a failed ping.Adds
WithChannelPingTimeout(default 5s) andWithChannelReconnectTimeout(default 10s) asChannelOptions, stored on the internalchannelstruct. When the health-check timer fires,Pingruns undercontext.WithTimeout(..., pingTimeout); on failure,reconnectruns under a separate timeout (default 10s).Also adjusts timer draining when a ping is received on the
c.pingchannel: it uses a non-blocking drain oftimer.Cinstead oftimer.Stop()plus blocking read, avoiding a possible block on the timer channel.Reviewed by Cursor Bugbot for commit 9719406. Bugbot is set up for automated code reviews on this repo. Configure here.