Add support to get cluster replica node for a given key#1581
Merged
vmihailenco merged 1 commit intoredis:masterfrom Dec 16, 2020
Merged
Add support to get cluster replica node for a given key#1581vmihailenco merged 1 commit intoredis:masterfrom
vmihailenco merged 1 commit intoredis:masterfrom
Conversation
vmihailenco
reviewed
Dec 16, 2020
| // This is because other redis commands generally have a flag that points that | ||
| // they are read only and automatically run on the replica nodes | ||
| // if ClusterOptions.ReadOnly flag is set to true. | ||
| func (c *ClusterClient) ReplicaForKey(ctx context.Context, key string) (*Client, error) { |
Collaborator
There was a problem hiding this comment.
I will rename this to SlaveForKey since we already have ForEachSlave.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on discord @vmihailenco this PR adds support to export commands that give the replica and master for a given key.