Merged
Conversation
Contributor
|
@colinodell thanks for putting up this PR, I'll get this reviewed today |
karanthukral
approved these changes
Jul 18, 2025
Contributor
karanthukral
left a comment
There was a problem hiding this comment.
Thanks for the contribution
jessicayuen
approved these changes
Jul 18, 2025
Contributor
|
@colinodell Can I ask you to just update this branch with main, and I'll take care of getting it merged and tagged |
Contributor
Author
|
Updating now. Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
💸 TL;DR
This fixes the race condition described in #71 and eliminates two unnecessary client calls for new objects using
generatedName📜 Details
Prior to this PR, new objects using
generatedNamefollowed a different code path from those not using this feature. That code path contained a potential race condition if theGet()method immediately following theCreate()failed to return the newly-created object. Aligning how we handle both types of new objects avoids this problem.🧪 Testing Steps / Validation
generatedNameobjects(Note that I was unable to replicate the race condition with envtest - only Kind - thus no regression test for the race condition)
✅ Checks