Skip to content

Expose additional required leader election configs#47

Merged
jessicayuen merged 3 commits intomainfrom
jyuen/leader-election
May 20, 2025
Merged

Expose additional required leader election configs#47
jessicayuen merged 3 commits intomainfrom
jyuen/leader-election

Conversation

@jessicayuen
Copy link
Copy Markdown
Member

@jessicayuen jessicayuen commented May 19, 2025

💸 TL;DR

Exposes CLI knobs for LeaderElectionID, LeaderElectionNamespace, and RenewDeadline which are all mandatory configurations that must be specified when enabling leader election.

Also optionally expose LeaseDuration for configuration since this setting must be increased if RenewDeadline is bumped.

See inline comments for details on these settings.

🧪 Testing Steps / Validation

I used these settings in our internal OCM on EKS and was able to see this error go away:

fatal: building manager: constructing manager: LeaderElectionID must be configured

OCM pods were able to progress with no further CLBO.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@jessicayuen jessicayuen marked this pull request as ready for review May 19, 2025 19:53
@jessicayuen jessicayuen requested a review from a team as a code owner May 19, 2025 19:53
@jessicayuen jessicayuen requested a review from harveyxia May 19, 2025 19:53
@jessicayuen jessicayuen merged commit 33e87f1 into main May 20, 2025
1 check passed
@jessicayuen jessicayuen deleted the jyuen/leader-election branch May 20, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants