💸 TL;DR

Adds new result types for modeling new FSM control flow scenarios: DoneResultWithStatusCondition and DoneAndRequeueAfterCompletion[WithBackoff]

Changes

1. DoneResultWithStatusCondition allows marking a state as completed with a custom status condition status (the boolean), message, and reason.
   1. This is useful when callers want freedom to customize any of these fields (like setting the status condition to False even though it completed without error)
2. DoneAndRequeueAfterCompletion[WithBackoff] allows the caller to requeue at the end of the FSM (i.e. after Reconcile() returns). This is useful for modeling scenarios where you want to requeue but also execute all subsequent FSM states. Edge case semantics:
   1. Subsequent states returning this result type take precedence.
   2. This result type can be pre-empted by any subsequent state returning a requeue or error result.
3. Behavior change: The FSM reconciler now correctly sets the Ready status condition as the conjunction of all other conditions. If any conditions are failed, the Ready condition's message will include the failed status conditions.
   1. This may break existing users tests if they assert on the contents of the Ready condition

Other Notes

1. We previously had no explicit test coverage of the result types (they were only implicitly functionally tested in the context of other tests like the envtest IT). I've added explicit table-driven tests covering all result types.
2. To achieve 1, I had to plumb through WithSkipNameValidation to the FSM builder. There's some global state that controller-runtime tracks to prevent multiple reconcilers registering with the same name.
3. To achieve 1, I had to add a builder method Reconciler(...) reconcile.TypedReconciler[ctrl.Request] so callers can extract the underlying controller-runtime reconciler

✅ Checks

• CI tests (if present) are passing
• Adheres to code style for repo
• Contributor License Agreement (CLA) completed if not a Reddit employee

I also tested this against reddit/achilles's suite of envtests to provide confidence that the changes to the core FSM reconciler didn't break existing behavior (see here)