Merged
Conversation
karanthukral
approved these changes
May 1, 2025
kdorosh
approved these changes
May 1, 2025
erik-ringsmuth
approved these changes
May 1, 2025
SriRamanujam
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This bug was introduced in this PR—we accidentally updated the observed event handler to rate limit all events, whereas controller-runtime's behavior is to only rate limit error and requeue (without specified delays) results.
Implications
Controllers subject to this bug, if rate limits are actively delaying new work from being enqueued, will see unexpected delays from when a trigger event fires in the cluster to when it is processed by the controller. Normally, triggers other than errors and requeues (without specified delays) should be enqueued immediately.
Worst case this behavior results in downstream user/system impact where they experience undue latency from a spec change to when it's instantiated.
This is the exact behavior I saw described here, which I never found the root cause of. With this one line change, the test succeeds, giving me confidence that this is the root cause of unexpected delays in processing.