@@ -50,7 +50,7 @@ describe("lsp.spawn", () => {
5050 { config : { lsp : true } } ,
5151 )
5252
53- it . instance ( "does not spawn builtin LSP for files inside instance when LSP is unset" , ( ) =>
53+ it . instance ( "spawns builtin LSP for files inside instance when LSP is unset" , ( ) =>
5454 LSP . Service . use ( ( lsp ) =>
5555 Effect . gen ( function * ( ) {
5656 const dir = ( yield * TestInstance ) . directory
@@ -62,14 +62,98 @@ describe("lsp.spawn", () => {
6262 line : 0 ,
6363 character : 0 ,
6464 } )
65- expect ( spy ) . toHaveBeenCalledTimes ( 0 )
65+ expect ( spy ) . toHaveBeenCalledTimes ( 1 )
66+ expect ( yield * lsp . status ( ) ) . toContainEqual ( {
67+ id : "typescript" ,
68+ name : "typescript" ,
69+ root : "" ,
70+ status : "error" ,
71+ } )
6672 } finally {
6773 spy . mockRestore ( )
6874 }
6975 } ) ,
7076 ) ,
7177 )
7278
79+ for ( const [ name , server , extension ] of [
80+ [ "TypeScript" , LSPServer . Typescript , ".ts" ] ,
81+ [ "Rust" , LSPServer . RustAnalyzer , ".rs" ] ,
82+ [ "Go" , LSPServer . Gopls , ".go" ] ,
83+ [ "Python" , LSPServer . Pyright , ".py" ] ,
84+ ] as const ) {
85+ it . instance ( `starts at most one ${ name } server per root` , ( ) =>
86+ LSP . Service . use ( ( lsp ) =>
87+ Effect . gen ( function * ( ) {
88+ const dir = ( yield * TestInstance ) . directory
89+ const root = spyOn ( server , "root" ) . mockResolvedValue ( dir )
90+ const spawn = spyOn ( server , "spawn" ) . mockResolvedValue ( undefined )
91+ const file = path . join ( dir , "src" , `inside${ extension } ` )
92+
93+ try {
94+ yield * Effect . all (
95+ [
96+ lsp . hover ( { file, line : 0 , character : 0 } ) ,
97+ lsp . definition ( { file, line : 0 , character : 0 } ) ,
98+ lsp . references ( { file, line : 0 , character : 0 } ) ,
99+ ] ,
100+ { concurrency : "unbounded" } ,
101+ )
102+ expect ( spawn ) . toHaveBeenCalledTimes ( 1 )
103+ } finally {
104+ root . mockRestore ( )
105+ spawn . mockRestore ( )
106+ }
107+ } ) ,
108+ ) ,
109+ )
110+ }
111+
112+ it . instance ( "publishes lsp.updated after failed initialization" , ( ) =>
113+ Effect . gen ( function * ( ) {
114+ const dir = ( yield * TestInstance ) . directory
115+ const lsp = yield * LSP . Service
116+ const updated = yield * Deferred . make < void > ( )
117+ const events = yield * EventV2Bridge . Service
118+ const unsubscribe = yield * events . listen ( ( event ) => {
119+ if ( event . type === LSP . Event . Updated . type ) Deferred . doneUnsafe ( updated , Effect . void )
120+ return Effect . void
121+ } )
122+ yield * Effect . addFinalizer ( ( ) => unsubscribe )
123+ const spy = spyOn ( LSPServer . Typescript , "spawn" ) . mockResolvedValue ( undefined )
124+
125+ try {
126+ yield * lsp . touchFile ( path . join ( dir , "src" , "inside.ts" ) )
127+ yield * awaitWithTimeout ( Deferred . await ( updated ) , "lsp.updated event was not published" )
128+ } finally {
129+ spy . mockRestore ( )
130+ }
131+ } ) ,
132+ )
133+
134+ it . instance (
135+ "does not spawn builtin LSP when explicitly disabled" ,
136+ ( ) =>
137+ LSP . Service . use ( ( lsp ) =>
138+ Effect . gen ( function * ( ) {
139+ const dir = ( yield * TestInstance ) . directory
140+ const spy = spyOn ( LSPServer . Typescript , "spawn" ) . mockResolvedValue ( undefined )
141+
142+ try {
143+ yield * lsp . hover ( {
144+ file : path . join ( dir , "src" , "inside.ts" ) ,
145+ line : 0 ,
146+ character : 0 ,
147+ } )
148+ expect ( spy ) . toHaveBeenCalledTimes ( 0 )
149+ } finally {
150+ spy . mockRestore ( )
151+ }
152+ } ) ,
153+ ) ,
154+ { config : { lsp : false } } ,
155+ )
156+
73157 it . instance (
74158 "would spawn builtin LSP for files inside instance when lsp is true" ,
75159 ( ) =>
0 commit comments