Skip to content

Commit b6a1f95

Browse files
authored
fix(app): preserve file search results while loading (anomalyco#43836)
1 parent f357e70 commit b6a1f95

3 files changed

Lines changed: 41 additions & 3 deletions

File tree

‎packages/app/e2e/regression/file-browser-sidebar-tab-switch.spec.ts‎

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,39 @@ test("keeps the file-browser sidebar mounted when switching file tabs", async ({
6060
await expect.poll(() => viewport.evaluate((element) => element.scrollTop)).toBe(scrolled)
6161
})
6262

63+
test("keeps previous file search results visible while the next search loads", async ({ page }) => {
64+
const searchPending = Promise.withResolvers<void>()
65+
await setup(page, async ({ query }) => {
66+
if (query === "file-0") return ["file-00.ts"]
67+
if (query === "file-7") {
68+
await searchPending.promise
69+
return ["file-79.ts"]
70+
}
71+
return []
72+
})
73+
74+
await page.goto(`/server/${base64Encode(server)}/session/${sessionID}`)
75+
await expectSessionTitle(page, title)
76+
77+
const panel = page.locator("#review-panel")
78+
await panel.getByRole("button", { name: "Open file" }).click()
79+
const filter = panel.getByRole("combobox", { name: "Filter files" })
80+
await filter.fill("file-0")
81+
await expect(panel.getByRole("option", { name: "file-00.ts" })).toBeVisible()
82+
83+
const nextSearch = page.waitForRequest((request) => {
84+
const url = new URL(request.url())
85+
return url.pathname === "/find/file" && url.searchParams.get("query") === "file-7"
86+
})
87+
await filter.fill("file-7")
88+
await nextSearch
89+
await expect(panel.getByRole("option", { name: "file-00.ts" })).toBeVisible()
90+
91+
searchPending.resolve()
92+
await expect(panel.getByRole("option", { name: "file-79.ts" })).toBeVisible()
93+
await expect(panel.getByRole("option", { name: "file-00.ts" })).toBeHidden()
94+
})
95+
6396
type Probed = HTMLElement & { __e2eProbe?: string }
6497

6598
async function writeProbe(page: Page) {
@@ -74,7 +107,10 @@ async function readProbe(page: Page) {
74107
.evaluate((el) => (el as Probed).__e2eProbe)
75108
}
76109

77-
async function setup(page: Page) {
110+
async function setup(
111+
page: Page,
112+
findFiles?: (input: { query: string; dirs?: string; limit?: number }) => unknown | Promise<unknown>,
113+
) {
78114
await mockOpenCodeServer(page, {
79115
directory,
80116
project: {
@@ -119,6 +155,7 @@ async function setup(page: Page) {
119155
}))
120156
},
121157
fileContent: (path) => ({ type: "text", content: `contents:${path}` }),
158+
findFiles,
122159
pageMessages: () => ({ items: [] }),
123160
})
124161

‎packages/app/e2e/utils/mock-server.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export interface MockServerConfig {
2626
questions?: unknown[] | (() => unknown[])
2727
fileList?: (path: string) => unknown | Promise<unknown>
2828
fileContent?: (path: string) => unknown | Promise<unknown>
29-
findFiles?: (input: { query: string; dirs?: string; limit?: number }) => unknown
29+
findFiles?: (input: { query: string; dirs?: string; limit?: number }) => unknown | Promise<unknown>
3030
sessionStatus?: Record<string, unknown> | (() => Record<string, unknown>)
3131
}
3232

‎packages/app/src/pages/session/v2/session-file-browser-tab.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createMemo, createSignal, createUniqueId, Show } from "solid-js"
2-
import { createQuery } from "@tanstack/solid-query"
2+
import { createQuery, keepPreviousData } from "@tanstack/solid-query"
33
import { Icon } from "@opencode-ai/ui/icon"
44
import { SessionFilePanelV2, SessionFilePanelV2Empty } from "@opencode-ai/session-ui/v2/session-file-panel-v2"
55
import { SessionReviewV2Sidebar } from "@opencode-ai/session-ui/v2/session-review-v2"
@@ -50,6 +50,7 @@ export function SessionFileBrowserTab(props: {
5050
queryKey: ["session-open-file", workspaceKey(), value] as const,
5151
enabled: value.length > 0,
5252
queryFn: ({ signal }) => file.searchFiles(value, { limit: 200, signal }),
53+
placeholderData: keepPreviousData,
5354
}
5455
})
5556
const files = createMemo(() => {

0 commit comments

Comments
 (0)