fix: Attempt to assign property type on null error#979
Merged
samsonasik merged 4 commits intorectorphp:mainfrom Oct 9, 2021
ishanvyas22:bug-6725
Merged
fix: Attempt to assign property type on null error#979samsonasik merged 4 commits intorectorphp:mainfrom ishanvyas22:bug-6725
samsonasik merged 4 commits intorectorphp:mainfrom
ishanvyas22:bug-6725
Conversation
Signed-off-by: Ishan Vyas <[email protected]>
samsonasik
reviewed
Oct 8, 2021
rules-tests/CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/bug_6725.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Oct 9, 2021
...CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/overlapped_key_param.php.inc
Outdated
Show resolved
Hide resolved
…ector/Fixture/overlapped_key_param.php.inc Co-authored-by: Abdul Malik Ikhsan <[email protected]>
samsonasik
approved these changes
Oct 9, 2021
samsonasik
reviewed
Oct 9, 2021
...CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/overlapped_key_param.php.inc
Show resolved
Hide resolved
Member
|
Thank you @ishanvyas22 |
Contributor
Author
|
Thanks. Would it be possible to add "hacktoberfest-accepted" label to this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#6725
This error is raised when there's discrepancies between params and phpDocParams. That means, for example, if method accepts 2 params and phpDoc block is only added for any one of param, in that case this issue is raised.
The reason for the issue is depending on phpDoc $key variable. I tried to check it with param name but it added a duplicated
@paramtag in docBlock. So as a temporary fix I addedissetcheck for now, so there's no notice/error is raised.