[TypeDeclaration] Handle param description in next line on ParamTypeDeclarationRector#969
[TypeDeclaration] Handle param description in next line on ParamTypeDeclarationRector#969TomasVotruba merged 4 commits intomainfrom
Conversation
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Using: https://github.com/palantirnet/drupal-rector I am not sure why it is still removing the @param docs. My rector.php file is: |
|
Sadly, I've seen this too. Here is a demo https://getrector.org/demo/1ec39364-dbe0-6a5a-9487-95acf2ddf76b. In addition, the demo shows that |
|
The demo is not using latest dev-main, could you try |
|
I just tried with dev-main and it is working better, but not perfect. Here
is a demo which removes too much doxygen. I know that demo is expected to
fail but it removes too much with dev-main as well
https://getrector.org/demo/1ec41507-8066-62ae-9479-77a5c1b53986
… |
|
@weitzman thank you for verify, could you create failing test case for it? Thank you. |
|
I added failing tests for three different rectors that do not leave the The demo links provided by @weitzman don't seem to work anymore so I cannot tell if it is the same problem. |

Closes #968 Fixes rectorphp/rector#6722