Fix MultiDirnameRector #6796
Merged
Fix MultiDirnameRector #6796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-granados
commented
Mar 20, 2025
| @@ -7,16 +7,6 @@ function multiDirname() | |||
| dirname(dirname($path)); | |||
|
|
|||
| new dirname(dirname(dirname($path))); | |||
|
|
|||
|
|
|||
| // untouched | |||
There was a problem hiding this comment.
Moved these cases to a new file to be able to check that the rule is not actually applied
carlos-granados
commented
Mar 20, 2025
|
|
||
| dirname($path, 1); | ||
|
|
||
| dirname($path, 2); |
There was a problem hiding this comment.
In these cases the rule would have been applied even though no actual change was made in the code
carlos-granados
commented
Mar 20, 2025
| @@ -56,12 +56,14 @@ public function refactor(Node $node): ?Node | |||
| $activeFuncCallNode = $node; | |||
| $lastFuncCallNode = $node; | |||
|
|
|||
| $shouldUpdate = false; | |||
There was a problem hiding this comment.
We check that there is at least one nested dirname call, if not the rule is not applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #6794