Fix ArgumentDefaultValueReplacer #6795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-granados
commented
Mar 20, 2025
| @@ -6,6 +6,7 @@ class VersionCompare | |||
| { | |||
| public function run() | |||
| { | |||
| version_compare($a, $b, $c); | |||
There was a problem hiding this comment.
Case where previously the rule would have been applied even though no code was changed
There was a problem hiding this comment.
Could you extract this one a to a new "skip_*" file?
carlos-granados
commented
Mar 20, 2025
| @@ -113,15 +113,17 @@ private function processArgs( | |||
| $replaceArgumentDefaultValue->getValueBefore() | |||
| ) && $argValue === $replaceArgumentDefaultValue->getValueBefore()) { | |||
| $expr->args[$position] = $this->normalizeValueToArgument($replaceArgumentDefaultValue->getValueAfter()); | |||
| return $expr; | |||
There was a problem hiding this comment.
Only return an Expr if the expr is actually changed, so that the rule is not applied if no change is made
carlos-granados
force-pushed
the
fix-ArgumentDefaultValueReplacer
branch
2 times, most recently
from
c49d752 to
f240f5d
Compare
samsonasik
reviewed
Mar 21, 2025
...tor/FuncCall/FunctionArgumentDefaultValueReplacerRector/Fixture/skip_version_compare.php.inc
Outdated
Show resolved
Hide resolved
carlos-granados
force-pushed
the
fix-ArgumentDefaultValueReplacer
branch
from
f240f5d to
7b2626f
Compare
|
Thank you @carlos-granados |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #6794