Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip void return on callback docblock on AddArrowFunctionReturnTypeRector #6780

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[TypeDeclaration] Skip void return on callback docblock on AddArrowFunctionReturnTypeRector #6780

merged 1 commit into from
Mar 12, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

@BackEndTea I handled it by verify native return is mixed, but docblock return is null

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 61cb7b5 into main Mar 12, 2025
44 checks passed
@samsonasik samsonasik deleted the skip-void-callback-doc branch March 12, 2025 15:12
@BackEndTea
Copy link

Thanks @samsonasik !

TomasVotruba
TomasVotruba reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of AddArrowFunctionReturnTypeRector when dealing with a generic void return
3 participants
@samsonasik @BackEndTea @TomasVotruba