Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Handle crash with nested method on AddParamTypeBasedOnPHPUnitDataProviderRector #6772

Merged
merged 1 commit into from
Mar 7, 2025
Merged

[TypeDeclaration] Handle crash with nested method on AddParamTypeBasedOnPHPUnitDataProviderRector #6772

merged 1 commit into from
Mar 7, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @grandmaster44 , I skipped this since it require to get actual method target which make it dynamic.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 01e60df into main Mar 7, 2025
44 checks passed
@samsonasik samsonasik deleted the crash-nestered branch March 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AddParamTypeBasedOnPHPUnitDataProviderRector] nested data providers
1 participant
@samsonasik