Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Handle crash first class callable on InlineArrayReturnAssignRector #6763

Merged
merged 1 commit into from
Mar 2, 2025
Merged

[CodeQuality] Handle crash first class callable on InlineArrayReturnAssignRector #6763

merged 1 commit into from
Mar 2, 2025

Conversation

samsonasik
Copy link
Member

@TomasVotruba your PR

cause crash on first class callable

There was 1 failure:

1) Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\InlineArrayReturnAssignRectorTest::test with data set #12 ('/Users/samsonasik/www/rector-...hp.inc')
assert(!$this->isFirstClassCallable())

/Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:32
/Users/samsonasik/www/rector-src/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php:193

This PR fix it.

@samsonasik samsonasik mentioned this pull request Mar 2, 2025
Merged
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit a732689 into main Mar 2, 2025
44 checks passed
@samsonasik samsonasik deleted the crash-first branch March 2, 2025 15:31
@TomasVotruba
Copy link
Member

Good point, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba