Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ChangesReporting): add GitHub output formatter #6747

Merged

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Feb 20, 2025

Add a new reporting output formatter for GitHub:

Example:

Summary annotations

image

PR view

image

@samsonasik
Copy link
Member

It seems make error test on windows https://github.com/rectorphp/rector-src/actions/runs/13434456653/job/37533464274?pr=6747

@neilime neilime force-pushed the feat/add-github-output-formatter branch 2 times, most recently from 9053336 to 7185c7d Compare February 20, 2025 12:39
@@ -16,15 +16,17 @@
/**
* @var string
* @see https://en.wikipedia.org/wiki/Diff#Unified_format
* @see https://regex101.com/r/AUPIX4/1
* @see https://regex101.com/r/sohQIG/1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use increase number over generate new one, you can click "Update Regex" instead of "Save new Regex"

just on final change when this PR is ready so only change /1 to /2 so we have history on regex1.com on what the different with previous approach

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no problem, I didn't want change the original one by myself (at least without your permission)

@neilime neilime force-pushed the feat/add-github-output-formatter branch 3 times, most recently from a4e705e to a5f2745 Compare February 20, 2025 13:33
@neilime neilime requested a review from samsonasik February 20, 2025 13:35
@neilime neilime force-pushed the feat/add-github-output-formatter branch from 34b0f04 to b92a1d7 Compare February 20, 2025 14:14
@neilime neilime requested a review from samsonasik February 20, 2025 14:14
@neilime
Copy link
Contributor Author

neilime commented Feb 24, 2025

@samsonasik do you need anything else for this PR? Let me know.

@samsonasik
Copy link
Member

I am ok on this, I will let @TomasVotruba decide for merging

@TomasVotruba
Copy link
Member

Thank you 👍

Let's try this out

@TomasVotruba TomasVotruba merged commit b5af1e4 into rectorphp:main Feb 24, 2025
44 checks passed
@rcerljenko
Copy link

is this auto-enabled when in github CI or do we need to manualy enable this via CLI flag? and if so, can you provide an example for the CLI flag to enable this.... thanks

@rcerljenko
Copy link

oh nevermind i see.. it's --output-format=github

@neilime neilime deleted the feat/add-github-output-formatter branch March 4, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants