[CodeQuality] Skip unused static methods in LocallyCalledStaticMethodToNonStaticRector, as should be handled by another rule #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-skip-non-static
branch
from
73ce5a6 to
3c20bd8
Compare
…ToNonStaticRector, as should be handled by another rule
TomasVotruba
force-pushed
the
tv-skip-non-static
branch
from
8ebdbd7 to
27e0fd8
Compare
samsonasik
reviewed
Feb 11, 2025
| { | ||
| public static function run() | ||
| { | ||
| $result = self::anotherStatic(); |
There was a problem hiding this comment.
the self::anotherStatic() one should be processed, as it called, that mean it is used, the verification seems on current method over the caller one.
I will check on it.
There was a problem hiding this comment.
It should not, as this method is static
There was a problem hiding this comment.
ok, it skipped due to run() method is static, so it seems nothing to do with commented code, I will check more in case of regression of the patch, since current class name call seems only on ['self', 'static'], which current class name for ClassName::execute() is not included.
There was a problem hiding this comment.
I create new PR for actual fixture for never called, with non-static method run()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.