Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readonly by default on new promoted property #6650

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-readonly-add-ctor branch 2 times, most recently from 660f983 to 659e2a3 Compare January 5, 2025 17:15
@samsonasik
Copy link
Member

@TomasVotruba we need immediate new rector release due to error on PHPStan 2.1.1, see PR;

should I wait for this one before releasing new tag?

@TomasVotruba
Copy link
Member Author

@samsonasik Yes, let's finish this one first

@samsonasik
Copy link
Member

@TomasVotruba ok, feel free to tag yourself once you finished it,

I am not sure if this will cause BC break without some flag, eg: $markReadonly so you can enable it on service you want to use it.

I guess 2.0.6 or 2.1 :)

@TomasVotruba
Copy link
Member Author

This targets ctors only, where all new dependencies are readonly by default.
Could you share example where this causes break?

@samsonasik
Copy link
Member

Ok, let's see how user will use it, especially on rector extensions, since method is public

/cc @driftingly @peterfox @simonschaufi FYI

@TomasVotruba TomasVotruba merged commit 8bc80b4 into main Jan 5, 2025
41 checks passed
@TomasVotruba TomasVotruba deleted the tv-readonly-add-ctor branch January 5, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants