Fix annotation on doctrine one #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 14, 2024
| @@ -9,7 +9,7 @@ final class WithValueAsArgument | |||
| * @When | |||
| * @When "this value is within quotes" | |||
| * @When this value has a ' character | |||
| * @When(key="value") this annotation has parameters so won't use this option | |||
There was a problem hiding this comment.
I think the description should be kept as comment when exists, when there is description outside (), which currently cause diff:
- #[\Behat\Step\When('(key="value")')]
+ #[\Behat\Step\When('(key="value")this annotation has parameters so won\'t use this option')]which should be:
- #[\Behat\Step\When('(key="value")')]
+ #[\Behat\Step\When('(key="value")')] // this annotation has parameters so won't use this optionI will look into it when possible.
There was a problem hiding this comment.
I haven't seen this case in any codebase yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.