feat: add the option to use the annotation value as an argument to the attribute #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
approved these changes
Nov 24, 2024
|
Thank you 😊 |
|
@carlos-granados I thought this includes the Behat tests as well, only when I tried to run it :D Could you add behat set as well and include it in |
carlos-granados
deleted the
use-annotation-value-as-attribute-argument
branch
|
@TomasVotruba I created a PR for this, please let me know if it is ok #6510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have an annotation like the ones Behat uses:
When you use the
AnnotationToAttributeRectorrule configured like this:The value of the annotation ("the user does not exist in the database") is discarded and the end result is:
This PR adds a new
useValueAsAttributeArgumentoption to theAnnotationToAttributeclass. If this option is set to true, the value of the annotation will be used as an argument for the attribute, resulting in the correct result of:This option only applies to "generic" annotations. If Rector considers an annotation to be a "doctrine" annotation (for example if the annotation has parameters) then this won't apply