[Renaming] Fix space on union docblock during rename on RenameClassRector #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems equal with old behaviour, which on server right now (on 18:59 my time) still using phpstan 1 and phpdoc-parser v1, as not yet deployed for latest v2
so it is not new behaviour |
|
Looking on PHPStan doc parser v1, it already has space: On v2, it has space as well |
|
@TomasVotruba fixed 🎉 🎉 🎉 |
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let see if the reprint from phpdoc-parser is fixable.