[TypeDeclaration] Handle nullable MockObject on TypedPropertyFromCreateMockAssignRector#6179
Merged
samsonasik merged 3 commits intomainfrom Jul 23, 2024
Merged
[TypeDeclaration] Handle nullable MockObject on TypedPropertyFromCreateMockAssignRector#6179samsonasik merged 3 commits intomainfrom
samsonasik merged 3 commits intomainfrom
Conversation
…teMockAssignRector
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Comment on lines
+109
to
+111
| if (! $classReflection instanceof ClassReflection) { | ||
| $classReflection = $this->reflectionResolver->resolveClassReflection($node); | ||
| } |
Member
There was a problem hiding this comment.
This should not be needed.
Member
Author
There was a problem hiding this comment.
it initialized as null before loop, I don't want to get class reflection when class doesn't have property, so early instanceof is used for tweak, then early skip when it got null
Member
There was a problem hiding this comment.
This rule should be simple as possible. Please remove the $classReflection = $this->reflectionResolver->resolveClassReflection($node); and use simple check as before.
Also, wait for review before next merges. I need to review those first
...n/Rector/Class_/TypedPropertyFromCreateMockAssignRector/Fixture/nullable_mock_object.php.inc
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #6178 (review)