All checks have passed 🎉 @TomasVotruba it is ready for review.

We're trying to separate PHP declaration rules (https://github.com/rectorphp/rector-src/blob/main/config/set/type-declaration-strict.php) and doblock rules (https://github.com/rectorphp/rector-src/blob/main/config/set/type-declaration.php).

It would be better to have this as a separated rule in a docblock rules. Type declarations and docblocks have different priorities and can behave differently. The optional configuration of the rule can be easily overlooked.

That's why it should extracted in a separated rule level. E.g. InlineVarDocToTypedPropertyRector

Could you add that one?

I will try.

@TomasVotruba as existing TypedPropertyRector is changing based on @var

It seems will be duplicated/ambiguous while adding feature for protected and public, it seems we need to create 2 new rules instead:

• InlineVarDocToTypedInPrivatePropertyRector
• InlineVarDocToTypedPropertyRector

The InlineVarDocToTypedPropertyRector can extends the InlineVarDocToTypedInPrivatePropertyRector with override the shouldSkip() method.

After that, remove the TypedPropertyRector
After that, register InlineVarDocToTypedInPrivatePropertyRector to php74 service set config
After that, register InlineVarDocToTypedPropertyRector to type-declaration service set config
After that, remove TypedPropertyRector from list service in https://getrector.org/demo page,

what do you think?

@samsonasik It seems pretty complicated, you're right.

Let's take this way then, with explicit option name:

  $services->set(TypedPropertyRector::class)
             ->configure([TypedPropertyRector::INLINE_PUBLIC => true]);

@TomasVotruba ok, implemented with set INLINE_PUBLIC option, default to false, when enabled to true, it will appy change to public and protected as well when not forbidden.

All checks have passed 🎉 @TomasVotruba I think it is ready.

Looks good, thank you 👍