Add test for nested annotation with SQL string argument#1515
Closed
oojacoboo wants to merge 3 commits intorectorphp:mainfrom
Closed
Add test for nested annotation with SQL string argument#1515oojacoboo wants to merge 3 commits intorectorphp:mainfrom
oojacoboo wants to merge 3 commits intorectorphp:mainfrom
Conversation
Member
|
@oojacoboo I cherry-picked your commit at PR #1516 |
TomasVotruba
pushed a commit
that referenced
this pull request
Dec 18, 2021
…AttributeRector (#1516) * Add test with SQL in nested annotation argument * update fixture namespace * Closes #1515 Fixes rectorphp/rector#6859 * [ci-review] Rector Rectify * clean up * clean up Co-authored-by: Jacob Thomason <[email protected]> Co-authored-by: GitHub Action <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a single file/test
sql_statement.php.inc. This was added to the 8.1 fixtures for thePhp80dir. However, I believe these tests should all be inPhp81. The organization seems a bit sloppy.When running the tests, I get the following error:
Honestly, the PHPUnit stack-trace isn't helpful. I have no idea where that error actually originates. That's due to the way the tests are designed with these include files. Nonetheless, I think this test is sufficient to setup and illustrate the syntax parsing issue.
Closes rectorphp/rector#6859