[Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x#1474
Merged
TomasVotruba merged 1 commit intomainfrom Dec 13, 2021
Merged
[Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x#1474TomasVotruba merged 1 commit intomainfrom
TomasVotruba merged 1 commit intomainfrom
Conversation
Member
Author
|
/cc @W0rma |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
changed the title
Member
|
Thank you 👍 |
|
@samsonasik Thank you very much! 👍 |
This was referenced Dec 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#6864 that the issue happen since rector 0.12.7 in php 7.x
Ref https://github.com/laminas/laminas-servicemanager-migration/runs/4485249466?check_suite_focus=true#step:3:213