Skip to content

Commit ff45ce6

Browse files
TomasVotrubaTomasVotruba
authored
Remove dead classes #2, remove unused PlatformAgnosticAssertions, remove ConsoleShowOutputFormatter (#1134)
* remove daed classes * make show output format simple again, just CLI output as helper command * move MethodCallManipulator to rector-nette * cleanup
1 parent b7d37b8 commit ff45ce6

File tree

17 files changed

+38
-722
lines changed

17 files changed

+38
-722
lines changed

‎.github/workflows/code_analysis.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ jobs:
3737
name: 'Commented Code'
3838
run: vendor/bin/easy-ci check-commented-code src packages rules tests packages-tests rules-tests --line-limit 5 --ansi
3939

40-
# -
41-
# name: 'Active Classes'
42-
# run: vendor/bin/easy-ci check-active-class src packages rules --ansi
40+
-
41+
name: 'Active Classes'
42+
run: vendor/bin/easy-ci check-active-class bin config src packages rules --ansi
4343

4444
# see https://github.com/rectorphp/rector-generator
4545
-

‎easy-ci.php‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,27 @@
22

33
declare(strict_types=1);
44

5+
use PHPStan\PhpDocParser\Parser\TypeParser;
56
use Rector\CodingStyle\Contract\ClassNameImport\ClassNameImportSkipVoterInterface;
7+
use Rector\Core\Contract\Console\OutputStyleInterface;
68
use Rector\Core\Contract\PHPStan\Reflection\TypeToCallReflectionResolver\TypeToCallReflectionResolverInterface;
79
use Rector\Core\Contract\Processor\FileProcessorInterface;
810
use Rector\Core\Contract\Rector\RectorInterface;
11+
use Rector\Core\NodeManipulator\MethodCallManipulator;
12+
use Rector\DependencyInjection\NodeManipulator\PropertyConstructorInjectionManipulator;
13+
use Rector\FileFormatter\Contract\Formatter\FileFormatterInterface;
14+
use Rector\Naming\Contract\Guard\ConflictingNameGuardInterface;
915
use Rector\NodeNameResolver\Contract\NodeNameResolverInterface;
1016
use Rector\NodeTypeResolver\Contract\NodeTypeResolverInterface;
17+
use Rector\NodeTypeResolver\DependencyInjection\PHPStanServicesFactory;
18+
use Rector\NodeTypeResolver\Reflection\BetterReflection\RectorBetterReflectionSourceLocatorFactory;
1119
use Rector\Php80\Contract\StrStartWithMatchAndRefactorInterface;
1220
use Rector\PHPStanStaticTypeMapper\Contract\TypeMapperInterface;
1321
use Rector\ReadWrite\Contract\ReadNodeAnalyzerInterface;
1422
use Rector\Set\Contract\SetListInterface;
1523
use Rector\StaticTypeMapper\Contract\PhpDocParser\PhpDocTypeMapperInterface;
1624
use Rector\StaticTypeMapper\Contract\PhpParser\PhpParserNodeMapperInterface;
25+
use Rector\Testing\PHPUnit\AbstractTestCase;
1726
use Rector\TypeDeclaration\Contract\TypeInferer\ParamTypeInfererInterface;
1827
use Rector\TypeDeclaration\Contract\TypeInferer\PropertyTypeInfererInterface;
1928
use Rector\TypeDeclaration\Contract\TypeInferer\ReturnTypeInfererInterface;
@@ -44,5 +53,18 @@
4453
NodeTypeResolverInterface::class,
4554
ReadNodeAnalyzerInterface::class,
4655
SetListInterface::class,
56+
ConflictingNameGuardInterface::class,
57+
TypeParser::class,
58+
RectorBetterReflectionSourceLocatorFactory::class,
59+
AbstractTestCase::class,
60+
PHPStanServicesFactory::class,
61+
OutputStyleInterface::class,
62+
FileFormatterInterface::class,
63+
MethodCallManipulator::class,
64+
// fix later - rector-symfony
65+
PropertyConstructorInjectionManipulator::class,
66+
// used in tests
67+
\Rector\FileSystemRector\Parser\FileInfoParser::class,
68+
\Rector\Defluent\NodeAnalyzer\SameClassMethodCallAnalyzer::class,
4769
]);
4870
};

‎packages-tests/BetterPhpDocParser/PhpDocParser/TypeNodeAnalyzerTest.php‎

Lines changed: 0 additions & 47 deletions
This file was deleted.

‎packages/BetterPhpDocParser/PhpDocParser/TypeNodeAnalyzer.php‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎packages/FamilyTree/NodeAnalyzer/PropertyUsageAnalyzer.php‎

Lines changed: 0 additions & 72 deletions
This file was deleted.

‎packages/ListReporting/Contract/Output/ShowOutputFormatterInterface.php‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎packages/ListReporting/Output/ConsoleShowOutputFormatter.php‎

Lines changed: 0 additions & 39 deletions
This file was deleted.

‎packages/Testing/PHPUnit/PlatformAgnosticAssertions.php‎

Lines changed: 0 additions & 85 deletions
This file was deleted.

‎packages/Testing/TestingParser/TestingParser.php‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
use Symplify\PackageBuilder\Parameter\ParameterProvider;
1414
use Symplify\SmartFileSystem\SmartFileInfo;
1515

16+
/**
17+
* @api
18+
*/
1619
final class TestingParser
1720
{
1821
public function __construct(

0 commit comments

Comments
 (0)