[PHPStanStaticTypeMapper] Improve UnionTypeMapper performance take 2 (#3688)

samsonasik · actions-user · web-flow · commit 931e6e24502a · 2023-04-26T11:35:16.000+07:00
* [PHPStanStaticTypeMapper] Improve UnionTypeMapper take 2

No need to verify bool and false exists when count types only 2 as already verified previously for all bool

* clean up

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action &lt;actions@github.com&gt;
diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php
@@ -246,29 +246,30 @@ private function resolveUnionTypes(PhpParserUnionType $phpParserUnionType): ?Php
             return null;
         }
 
+        if (count($phpParserUnionType->types) === 2) {
+            return $phpParserUnionType;
+        }
+
         $identifierNames = [];
         foreach ($phpParserUnionType->types as $type) {
             if ($type instanceof Identifier) {
                 $identifierNames[] = $type->toString();
             }
         }
-        
+
         if (! in_array('bool', $identifierNames, true)) {
             return $phpParserUnionType;
         }
-        
+
         if (! in_array('false', $identifierNames, true)) {
             return $phpParserUnionType;
         }
 
-        foreach ($phpParserUnionType->types as $key => $type) {
-            if ($type instanceof Identifier && $type->toString() === 'false') {
-                unset($phpParserUnionType->types[$key]);
-                $phpParserUnionType->types = array_values($phpParserUnionType->types);
-
-                return $phpParserUnionType;
-            }
-        }
+        $phpParserUnionType->types = array_filter(
+            $phpParserUnionType->types,
+            static fn(Node $node): bool => ! $node instanceof Identifier || $node->toString() !== 'false'
+        );
+        $phpParserUnionType->types = array_values($phpParserUnionType->types);
 
         return $phpParserUnionType;
     }
