Ignore phpdoc type in RecastingRemovalRector (#5841)

staabm · web-flow · commit 6eac87db32ef · 2024-04-22T16:33:11.000+07:00
diff --git a/rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_phpdoc.php.inc b/rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_phpdoc.php.inc
@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
+
+class SkipPhpDocTyped
+{
+    /** @param array{key: int} $arr */
+    public function run($arr = [])
+    {
+        echo "hello ". (int) $arr['key'];
+    }
+}
+
+?>
diff --git a/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php b/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php
@@ -96,7 +96,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $nodeType = $this->getType($node->expr);
+        $nodeType = $this->nodeTypeResolver->getNativeType($node->expr);
         if ($nodeType instanceof MixedType) {
             return null;
         }

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function refactor(Node $node): ?Node`
`96`	`96`	`return null;`
`97`	`97`	`}`
`98`	`98`
`99`		`- $nodeType = $this->getType($node->expr);`
	`99`	`+ $nodeType = $this->nodeTypeResolver->getNativeType($node->expr);`
`100`	`100`	`if ($nodeType instanceof MixedType) {`
`101`	`101`	`return null;`
`102`	`102`	`}`